Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14006] Prevent screenshot setting V2 #12570

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Dec 24, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14006

📔 Objective

#10707 was reverted because it caused the entire app to be invisible on some Windows and Mac configurations. This PR introduces the same setting, but default disabled.

Known non-screenshot configurations where this prevents the app from showing:

  • Remote desktop (anydesk/parsec/others) on Windows (expected and intended, but unexpected to some users)
  • Display link connected external displays on Mac (does this use the screencapture API on mac)
  • With Parsec virtual display driver installed

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Logo
Checkmarx One – Scan Summary & Details4190460f-a14e-4c66-ad12-ee8238e188b1

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2024-11115 Npm-electron-33.2.1 Vulnerable Package

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (0619ef5) to head (8aa7754).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/main/window.main.ts 0.00% 7 Missing ⚠️
.../src/platform/services/desktop-settings.service.ts 0.00% 5 Missing ⚠️
...pps/desktop/src/app/accounts/settings.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12570      +/-   ##
==========================================
- Coverage   33.78%   33.77%   -0.01%     
==========================================
  Files        2912     2912              
  Lines       90693    90714      +21     
  Branches    17151    17154       +3     
==========================================
  Hits        30641    30641              
- Misses      57666    57687      +21     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant