[PM-10915] Ownership does not default to the organization you are in when creating a new item

[LRNcardozoWDF]

🎟️ Tracking

PM-10915

📔 Objective

When adding an item after selecting an organization in vault filter, show that organization as owner in the add item view.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (b15f660) to head (76ef9cd).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   89.60%   89.61%           
=======================================
  Files         750      750           
  Lines       47035    47043    +8     
=======================================
+ Hits        42148    42156    +8     
  Misses       4887     4887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 3005d26c-14f4-47e4-8385-e87b5369bf87

Great job, no security vulnerabilities found in this Pull Request

[fedemkr]

🤔 Instead of using selectedOrganizationId I'd use ownerOrganizationId or even simpler organizationId.
The reason behind that is that other objects shouldn't need to know that something was selected or which was the operation from which you got the org id value. I think it's more important to state what that value represents for the flow so if in the future this flow is called from another place where the Org id comes from another place e.g. some external request or from the server then we'd need to refactor the name; however by using a simpler name stating what the value represents lowers the chances of needing a refactor for this.
Thoughts?

[LRNcardozoWDF]

@fedemkr Thank you for your feedback!
I agree with both approaches, my idea was to have code easier to read. On the other hand, choosing a simpler name could prevent further work/refactor. I'll change this to organizationId .