Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11712] Fix scroll going back to focus when scrolling and dismissing the keyboard #1339

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Feb 10, 2025

🎟️ Tracking

PM-11712

📔 Objective

Given the previous fix #1292 the scroll was behaving incorrectly and scrolling back to the field focused when scrolling away from such field causing a lot of confusion. So this PR fixes it by removing the KeyboardResponder and setting the scrollContentMargins constantly instead of depending on whether the keyboard is shown which has a better UX given that the animation doesn't jump and fixes the aforementioned issue.

📸 Screenshots

Before

Scroll.before.mov

After fix

Scroll.fixed.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (525d50c) to head (b99af77).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
- Coverage   89.61%   89.59%   -0.03%     
==========================================
  Files         752      752              
  Lines       47234    47234              
==========================================
- Hits        42330    42318      -12     
- Misses       4904     4916      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsdb28582e-41d1-4c79-bc6d-cdb8502687dc

Great job, no security vulnerabilities found in this Pull Request

@fedemkr fedemkr merged commit ea074f7 into main Feb 11, 2025
9 checks passed
@fedemkr fedemkr deleted the PM-11712/fix-scroll-bouncing-to-focus branch February 11, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants