Skip to content

Commit

Permalink
Fix and enable no-value-for-parameter lint
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanielmanistaatgoogle committed Mar 2, 2017
1 parent e151a21 commit d5e3766
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ dummy-variables-rgx=^ignored_|^unused_
#TODO: Enable unused-argument
#TODO: Enable fixme
#TODO: Enable wrong-import-order
#TODO: Enable no-value-for-parameter
#TODO: Enable cyclic-import
#TODO: Enable redefined-outer-name
#TODO: Enable too-many-instance-attributes
Expand All @@ -33,4 +32,4 @@ dummy-variables-rgx=^ignored_|^unused_
#TODO: Enable too-many-nested-blocks
#TODO: Enable super-init-not-called

disable=missing-docstring,too-few-public-methods,too-many-arguments,no-init,duplicate-code,invalid-name,suppressed-message,locally-disabled,protected-access,no-name-in-module,unused-argument,fixme,wrong-import-order,no-value-for-parameter,cyclic-import,redefined-outer-name,too-many-instance-attributes,broad-except,too-many-locals,too-many-lines,redefined-variable-type,next-method-called,import-error,useless-else-on-loop,too-many-return-statements,too-many-nested-blocks,super-init-not-called
disable=missing-docstring,too-few-public-methods,too-many-arguments,no-init,duplicate-code,invalid-name,suppressed-message,locally-disabled,protected-access,no-name-in-module,unused-argument,fixme,wrong-import-order,cyclic-import,redefined-outer-name,too-many-instance-attributes,broad-except,too-many-locals,too-many-lines,redefined-variable-type,next-method-called,import-error,useless-else-on-loop,too-many-return-statements,too-many-nested-blocks,super-init-not-called
2 changes: 1 addition & 1 deletion src/python/grpcio/grpc/beta/implementations.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ def dynamic_stub(channel, service, cardinalities, options=None):
Returns:
A face.DynamicStub with which RPCs can be invoked.
"""
effective_options = StubOptions() if options is None else options
effective_options = _EMPTY_STUB_OPTIONS if options is None else options
return _client_adaptations.dynamic_stub(
channel._channel, # pylint: disable=protected-access
service,
Expand Down

0 comments on commit d5e3766

Please sign in to comment.