Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticgraph demo app in docker with Opensearch #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwils
Copy link
Collaborator

@jwils jwils commented Feb 18, 2025

Add a docker file to the elasticgraph repo that creates a demo application with the default configurations depending on the current version of elasticgraph. This demo app can be booted in docker compose with the opensearch dependency for a quick single line command to try out elasticgraph using the demo schema.

To try it out:

Run
docker-compose up --build elasticgraph

after long build

open localhost:9393

@jwils jwils force-pushed the joshuaw/onestep/opensearch branch 4 times, most recently from 2965e8b to b052a92 Compare February 19, 2025 04:43
@jwils jwils changed the title Opensearch demo with hardcoded config. Opensearch demo app Feb 19, 2025
@jwils jwils marked this pull request as ready for review February 19, 2025 13:15
@jwils jwils force-pushed the joshuaw/onestep/opensearch branch from b052a92 to 52d1a5f Compare February 19, 2025 13:43
This uses the local version of elasticgraph to generate a
demo application in a docker container. The docker compose
file starts up the demo app & the related opensearch
dependency.

By Default the app will be avaiable on port 9393
@jwils jwils force-pushed the joshuaw/onestep/opensearch branch from 52d1a5f to 151eff4 Compare February 19, 2025 14:01
@jwils jwils changed the title Opensearch demo app Elasticgraph demo app with Opensearch Feb 19, 2025
@jwils jwils changed the title Elasticgraph demo app with Opensearch Elasticgraph demo app in docker with Opensearch Feb 19, 2025
Copy link
Collaborator

@myronmarston myronmarston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great job here @jwils! It's really nice to see the docker image come together like this.

I had some general ideas for improvement but I wanted to try to implement the improvement ideas myself since (1) I wanted to understand how this works better (I don't have a lot of experience with dockerfiles...) and (2) I need to be comfortable maintaining this going forward.

To that end, I put together my improvement ideas in a PR that stacks on top of this one: #215. I'd love your feedback on it.

If you're happy with the changes I made, we can go ahead and merge this PR to main and then merge mine (with any feedback you have addressed) as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants