Fix: changing tiling sprite anchor not updating view (pixijs#10513)

* - optimise remove child
- change the way render group is stored
- added parentRenderGroup
- renderGroup now the owned render group

* remove dead code

* optimise destroy remove children

* optimise the rendergroup

* fix test import

* finak clean up

* fix parent issue

* final tweaks
update tests tio be more readable

* lint

* fix tiling sprite anchor

---------

Co-authored-by: Zyie <[email protected]>

src/scene/container/container-mixins/effectsMixin.ts

@@ -58,6 +58,11 @@ export const effectsMixin: Partial<Container> = {
             renderGroup.structureDidChange = true;
         }
 
+        // if (this.renderGroup)
+        // {
+        //     this.renderGroup.structureDidChange = true;
+        // }
+
         this._updateIsSimple();
     },
     /**

src/scene/sprite-tiling/TilingSprite.ts

@@ -196,7 +196,14 @@ export class TilingSprite extends Container implements View, Instruction
 
         this.allowChildren = false;
 
-        this._anchor = new ObservablePoint(this);
+        this._anchor = new ObservablePoint(
+            {
+                _onUpdate: () =>
+                {
+                    this.onViewUpdate();
+                }
+            },
+        );
 
         this._applyAnchorToTexture = applyAnchorToTexture;
 

tests/renderering/sprite/TilingSprite.test.ts

@@ -185,4 +185,21 @@ describe('TilingSprite', () =>
             expect(tilingSprite.texture).toEqual(Texture.EMPTY);
         });
     });
+
+    describe('Anchor', () =>
+    {
+        it('should update anchor', () =>
+        {
+            const texture = new Texture();
+            const sprite = setup({ texture });
+
+            expect(sprite.texture).toEqual(texture);
+
+            const spy = jest.spyOn(sprite, 'onViewUpdate');
+
+            sprite.anchor.x = 0.5;
+
+            expect(spy).toHaveBeenCalledTimes(1);
+        });
+    });
 });

tests/scene/scene.tests.ts

@@ -578,6 +578,8 @@ describe('Scene', () =>
 
         compareUpdateList([child], container.renderGroup, 1);
 
+        expect(true).toBeTrue();
+
         // console.log(container2.layerGroup.childrenToUpdate[1])
         // expect(container2.layerGroup.childrenToUpdate[1]).toEqual({
         //     list: [child2, child3],