Skip to content

Commit

Permalink
Revert "websockets: continue listening for messages after parsing com…
Browse files Browse the repository at this point in the history
…pletion"

This reverts commit 9ea5f8a.

The one-shot behavior of receive_message was intentional, and simply
requeuing the old callback every time will eventually overflow the
stack due to repeated async_callback wrappers.  An alternate interface
that doesn't require receive_message to be called for every message
may be added in a future change.

See discussion at
http://github.com/facebook/tornado/commit/9ea5f8a277db96557ae7867375c7db4d8c5f633a
  • Loading branch information
Ben Darnell committed May 29, 2010
1 parent 7f8725c commit 70a3770
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tornado/websocket.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ def _on_frame_type(self, callback, byte):

def _on_end_delimiter(self, callback, frame):
callback(frame[:-1].decode("utf-8", "replace"))
self.receive_message(callback)

def _not_supported(self, *args, **kwargs):
raise Exception("Method not supported for Web Sockets")
Expand Down

0 comments on commit 70a3770

Please sign in to comment.