Skip to content

Commit

Permalink
angle safety tests: more clear helper function name
Browse files Browse the repository at this point in the history
here too
  • Loading branch information
sshane committed Apr 28, 2023
1 parent 001f991 commit 99809f7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions tests/safety/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ def _set_prev_desired_angle(self, t):
t = int(t * self.DEG_TO_CAN)
self.safety.set_desired_angle_last(t)

def _angle_meas_msg_array(self, angle):
def _reset_angle_measurement(self, angle):
for _ in range(6):
self._rx(self._angle_meas_msg(angle))

Expand All @@ -546,7 +546,7 @@ def test_angle_cmd_when_enabled(self):
max_delta_down = np.interp(s, self.ANGLE_DELTA_BP, self.ANGLE_DELTA_VU)

# first test against false positives
self._angle_meas_msg_array(a)
self._reset_angle_measurement(a)
self._rx(self._speed_msg(s)) # pylint: disable=no-member

self._set_prev_desired_angle(a)
Expand Down Expand Up @@ -591,7 +591,7 @@ def test_angle_cmd_when_disabled(self):

for steer_control_enabled in (True, False):
for angle_meas in np.arange(-90, 91, 10):
self._angle_meas_msg_array(angle_meas)
self._reset_angle_measurement(angle_meas)

for angle_cmd in np.arange(-90, 91, 10):
self._set_prev_desired_angle(angle_cmd)
Expand Down
4 changes: 2 additions & 2 deletions tests/safety/test_ford.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def setUp(self):
self.safety.set_safety_hooks(Panda.SAFETY_FORD, 0)
self.safety.init_tests()

def _reset_curvature_measurements(self, curvature, speed):
def _reset_curvature_measurement(self, curvature, speed):
self._rx(self._speed_msg(speed))
for _ in range(6):
self._rx(self._yaw_rate_msg(curvature, speed))
Expand Down Expand Up @@ -244,7 +244,7 @@ def test_steer_meas_delta(self):
for steer_control_enabled in (True, False):
for speed in np.linspace(0, 50, 11):
for initial_curvature in np.linspace(-self.MAX_CURVATURE, self.MAX_CURVATURE, 21):
self._reset_curvature_measurements(initial_curvature, speed)
self._reset_curvature_measurement(initial_curvature, speed)

limit_command = speed > self.CURVATURE_DELTA_LIMIT_SPEED
for new_curvature in np.linspace(-self.MAX_CURVATURE, self.MAX_CURVATURE, 41):
Expand Down

0 comments on commit 99809f7

Please sign in to comment.