Skip to content

Commit

Permalink
gpio: ab8500: write argument value instead of hardwired 1
Browse files Browse the repository at this point in the history
This fixes a bug in gpio_set_value(xxx, 0) for ab8500 GPIOs.

Change-Id: I9c50d527813b8817f0374e45d243e7bb6400b5c9
Signed-off-by: Marcel Tunnissen <[email protected]>
Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/32115
Reviewed-by: Jonas ABERG <[email protected]>
Tested-by: Jonas ABERG <[email protected]>
  • Loading branch information
Marcel Tunnissen authored and Robert Marklund committed Oct 5, 2011
1 parent 767fc29 commit 4d1eeba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-ab8500.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ static void ab8500_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
struct ab8500_gpio *ab8500_gpio = to_ab8500_gpio(chip);
int ret;
/* Write the data */
ret = ab8500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, 1);
ret = ab8500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val);
if (ret < 0)
dev_err(ab8500_gpio->dev, "%s write failed\n", __func__);
}
Expand Down

0 comments on commit 4d1eeba

Please sign in to comment.