-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dategen in three phases with slurm job #275
Conversation
What would be the impact of this change on local data generation, e.g. on just a single machine owned by Boa user? |
|
||
File input = new File(INPUT_PATH); | ||
|
||
DownloadWorker[] workers = new DownloadWorker[THREAD_NUM]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Boa code is intended to compile using Java 7 or higher, one could use concurrency features such as ExecutorService that is meant to provide all of these features. Just a thought. See https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be merged provided it works for the local data-generation. The enhancement to use advanced concurrency features could be done later.
|
||
boolean assigned = false; | ||
while (!assigned) { | ||
for (int j = 0; j < THREAD_NUM; j++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Boa code is intended to compile using Java 7 or higher, one could use concurrency features such as ExecutorService that is meant to provide all of these features. Just a thought. See https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html
These changes fix and optimize the JSON retriever for extracting repo metadata. GetReposByLanguage.java takes 4 arguments:
|
Download repositories: GitHubRepoBareDownloader.java
Generate seq files for each project: SeqRepoGenerator.java, SeqRepoBuilder.java, run-generator.sh, slurmJob.sh
Combine seq files: SeqRepoCombiner.java, run-combiner.sh