Skip to content

Commit

Permalink
[bitnami/cert-manager] Use custom probes if given (bitnami#12484)
Browse files Browse the repository at this point in the history
Without this change, in order to use a custom probe, the user has to
specify the probe parameters, and also must specify for the original
probe "enabled: false".

Issue: bitnami#12354
Signed-off-by: Orgad Shaneh <[email protected]>

Signed-off-by: Orgad Shaneh <[email protected]>
  • Loading branch information
orgads authored Sep 22, 2022
1 parent a1700ab commit c14cacf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion bitnami/cert-manager/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ sources:
- https://github.com/bitnami/containers/tree/main/bitnami/cert-manager-webhook
- https://github.com/bitnami/containers/tree/main/bitnami/cainjector
- https://github.com/jetstack/cert-manager
version: 0.8.2
version: 0.8.3
12 changes: 6 additions & 6 deletions bitnami/cert-manager/templates/webhook/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ spec:
{{- if .Values.webhook.customStartupProbe }}
startupProbe: {{- include "common.tplvalues.render" (dict "value" .Values.webhook.customStartupProbe "context" $) | nindent 12 }}
{{- end }}
{{- if .Values.webhook.livenessProbe.enabled }}
{{- if .Values.webhook.customLivenessProbe }}
livenessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.webhook.customLivenessProbe "context" $) | nindent 12 }}
{{- else if .Values.webhook.livenessProbe.enabled }}
livenessProbe:
httpGet:
path: {{ .Values.webhook.livenessProbe.path }}
Expand All @@ -134,10 +136,10 @@ spec:
timeoutSeconds: {{ .Values.webhook.livenessProbe.timeoutSeconds }}
successThreshold: {{ .Values.webhook.livenessProbe.successThreshold }}
failureThreshold: {{ .Values.webhook.livenessProbe.failureThreshold }}
{{- else if .Values.webhook.customLivenessProbe }}
livenessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.webhook.customLivenessProbe "context" $) | nindent 12 }}
{{- end }}
{{- if .Values.webhook.readinessProbe.enabled }}
{{- if .Values.webhook.customReadinessProbe }}
readinessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.webhook.customReadinessProbe "context" $) | nindent 12 }}
{{- else if .Values.webhook.readinessProbe.enabled }}
readinessProbe:
httpGet:
path: {{ .Values.webhook.readinessProbe.path }}
Expand All @@ -148,8 +150,6 @@ spec:
timeoutSeconds: {{ .Values.webhook.readinessProbe.timeoutSeconds }}
successThreshold: {{ .Values.webhook.readinessProbe.successThreshold }}
failureThreshold: {{ .Values.webhook.readinessProbe.failureThreshold }}
{{- else if .Values.webhook.customReadinessProbe }}
readinessProbe: {{- include "common.tplvalues.render" (dict "value" .Values.webhook.customReadinessProbe "context" $) | nindent 12 }}
{{- end }}
{{- if .Values.webhook.resources }}
resources: {{- toYaml .Values.webhook.resources | nindent 12 }}
Expand Down

0 comments on commit c14cacf

Please sign in to comment.