Implement a Rover navigation within a given terrain and based on a specified path #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndary limits The position is composed of the Terrain instead of the Rover. Appropriate changes are made accordingly. Additional misc changes added include: - Fix test description with regard to invalid Step - Add custom rubocop rules on cops to ignore - Fix rubocop related offenses
A position in itself can have x & y coordinates(in terms of being applicable to a two dimensional grid system) along with an orientation(i.e., one of the 4 cardinal compass points) and the ability for it to be applied to a given terrain, hence a generic Position class feels more appropriate here than a specific RoverPosition class. Also it makes sense that a Rover is composed of a Position and it needn't only have to be restricted to a Rover is composed of a RoverPosition and also in retrospect, the former sounds better.
…a rover has to traverse
- There is no current need for current position to be present in the public scope of methods - Rover can get the current location without knowing that the location method is defined on the current_position object by directly sending a message with : 'rover.current_location', hence refactored the code and exposed public methods only where and as much as needed
…cops automatically - Also add rubocop-performance cops to rubocop config fix to run related cops automatically - Ignore less important cops - Modify default values of certain cops as needed & reasonably appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a Rover navigation within the rectangular plateau