Fix undesirable artefacts during map zooming/cropping for some CRS #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 81.96% 81.96% -0.01%
==========================================
Files 6 6
Lines 2967 2966 -1
==========================================
- Hits 2432 2431 -1
Misses 535 535
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Plots in the vignette with examples from the slendr paper needed minor cosmetic updates. All done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #116. In particular, it reverses the order of
CRS transformation -> cropping, intocropping -> CRS transformationas explained here.This results in minor changes in the appearance of transformed maps (i.e. maps which use a projected CRS instead of the WGS-84/EPSG:4326 geodesic lat/lon coordinate system). The changes are, however, purely aesthetic and not functional. For an example see this.