Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing various gene flow errors #134

Merged
merged 6 commits into from
Apr 22, 2023
Merged

Fixing various gene flow errors #134

merged 6 commits into from
Apr 22, 2023

Conversation

bodkan
Copy link
Owner

@bodkan bodkan commented Apr 21, 2023

This finally addresses inconsistent error messages formally reported in #132.

Also simplifies and cleans up the gene_flow() code a bit in the process. No breaking changes or changes to the user-facing interface introduced by this (but I hope some yet-undiscovered issues will be correctly caught as a result of this).

@bodkan
Copy link
Owner Author

bodkan commented Apr 21, 2023

@IsabelMarleen: Still have to do more testing but I'm afraid it's already clear we will have to do the "gene flow happens earliest at +1 (or -1, for backwards time models) time point post split" as we discussed a couple of times.

For your demes project, issue a warning wherever an adjustment of this kind needs to be made during compilation from demes into slendr.

(This is not a priority though! Unless that's something that absolutely has to happen urgently, let's deal with this fully after your thesis is submitted. Focus on your 🐘 now. :))

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #134 (d7fad95) into main (1473227) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   83.77%   83.75%   -0.02%     
==========================================
  Files           6        6              
  Lines        3075     3072       -3     
==========================================
- Hits         2576     2573       -3     
  Misses        499      499              
Impacted Files Coverage Δ
R/interface.R 80.16% <100.00%> (-0.10%) ⬇️
R/utils.R 88.08% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodkan bodkan merged commit b7209f1 into main Apr 22, 2023
@bodkan bodkan deleted the fixing-gene-flow-errors branch April 22, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants