Merge pull request JochenHeckl#27 from JochenHeckl/wip

Add spacing above data source in inspector
bomberest · Jul 26, 2024 · a6dc0f3 · a6dc0f3
2 parents ead7db0 + bd57906
commit a6dc0f3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/Editor/Scripts/DataBindingEditorStyles.cs b/Editor/Scripts/DataBindingEditorStyles.cs
@@ -48,6 +48,11 @@ public static StyleSheet StyleSheet
             }
         }
 
+        internal static void DataSourceStyle(VisualElement visualElement)
+        {
+            visualElement.style.marginTop = 12;
+        }
+
         internal static void ErrorMessageStyle(VisualElement visualElement)
         {
             visualElement.style.marginTop = 12;

diff --git a/Editor/Scripts/Editors/ComponentPropertyBindingEditor.cs b/Editor/Scripts/Editors/ComponentPropertyBindingEditor.cs
@@ -11,7 +11,7 @@ internal class ComponentPropertyBindingEditor : BindingEditor<ComponentPropertyB
     {
         private DropdownField targetComponentSelectionDropdownField;
 
-        private readonly Type dataSourceType;
+        private new readonly Type dataSourceType;
         private readonly PropertyInfo[] bindableDataSourceProperties;
         private readonly Action bindingChanged;
 

diff --git a/Editor/Scripts/ViewEditorBase.cs b/Editor/Scripts/ViewEditorBase.cs
@@ -99,6 +99,8 @@ Action<Type> handleDataSourceTypeChanged
                     dataSource.Add(MakeOpenDataSourceButton(currentDataSourceType));
                 }
 
+                DataBindingEditorStyles.DataSourceStyle(dataSource);
+
                 return dataSource;
             }
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -99,6 +99,8 @@ Action<Type> handleDataSourceTypeChanged @@
                         dataSource.Add(MakeOpenDataSourceButton(currentDataSourceType));
                     }
+                    DataBindingEditorStyles.DataSourceStyle(dataSource);
                     return dataSource;
                 }
             }
@@ Expand Down @@