Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'npm' compatible Git repo reference for react-pdf-js #82

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Use 'npm' compatible Git repo reference for react-pdf-js #82

merged 1 commit into from
Aug 5, 2020

Conversation

sscholle
Copy link
Contributor

@sscholle sscholle commented Aug 4, 2020

Proposed changes

  • Use 'npm' compatible Git repo reference for react-pdf-js
  • support npm installation method via (npm install) with lockfile

Reason

  • our dogged dependency on Yarn has made it difficult to fully use 'npm' for our ecosystem. this commit will help bridge the gap between those very much same worlds

@sscholle
Use 'npm' compatible Git repo reference for react-pdf-js
20cbb19 
- support npm installation method via (npm install) with lockfile
@sscholle sscholle merged commit f0a8c82 into bonlineza:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musangowope musangowope Awaiting requested review from musangowope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sscholle @musangowope