upgrade node and react to match bonline applications #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabeloT
approved these changes
May 9, 2022
pruhesi
reviewed
May 13, 2022
| @@ -84,10 +84,10 @@ | |||
| "lodash": "^4.0.0", | |||
| "mocha": "^3.0.0", | |||
| "mocha-dynamic-tests": "^2.0.0", | |||
| "node-sass": "^3.4.2", | |||
| "react": "^16.12.0", | |||
| "node-sass": "^6.0.1", | |||
There was a problem hiding this comment.
@tmuzanenhamo are we sticking with text-mask?
Also you can drop node-sass i think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade node to version 16 and react to version 17
...
Types of changes
What type of changes does your code introduce?
Put an
xin the boxes that apply, leave blank if noneChecklist
Put an
xin the boxes that apply.yarn cypress:run)yarn lint && ./vendor/bin/phpunit)Dependant PRs
List Pull Requests below in format
#<ISSUE-NUMBER>Relevant Issues
https://app.asana.com/0/1199888180509071/1202149081681282
Description
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.