S3 backend #96
Open
S3 backend #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this backend. Did you do a performance comparison with rclone+s3? |
|
I didn't do a performance comparison with rclone no, but I am having issues when doing parallel uploads using rclone so I am trying to mitigate it by doing s3 requests directly from borgstore. Rclone would effectively stall for ~10 seconds after every batch of transfers. Additionally, since rclone is a separate process the data to be sent would be kept in memory twice, once by borgstore and once by rclone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented S3 backend.
The implementation was tested against a local Minio S3 server.