add flag: --sqldb #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
reviewed
Apr 11, 2024
shotizam.go
Outdated
| @@ -31,6 +31,7 @@ var ( | |||
| base = flag.String("base", "", "base file to diff from; must be in json format") | |||
| mode = flag.String("mode", "sql", "output mode; tsv, json, sql, nameinfo") | |||
| sqlite = flag.Bool("sqlite", false, "launch SQLite on data (when true, mode flag is ignored)") | |||
| sqldb = flag.String("sqldb", "", "save SQLite db (when set, mode and sqlite flag is ignored)") | |||
There was a problem hiding this comment.
as written, this sounds like a boolean flag. specify that this is the target filename to write the DB to?
There was a problem hiding this comment.
@bradfitz yep, it's the target db filename.
how about -o filename, then we can use it like this:
shotizam --sqlite -o bin-size.db /some/go.binary
shotizam --mode csv -o bin-size.csv /some/go.binary
shotizam --mode sql -o bin-size.sql /some/go.binary
There was a problem hiding this comment.
it's ready.
btw --mode nameinfo also support -o
shotizam --sqlite -o bin-size.db SELF
shotizam --mode nameinfo -o bin-size.txt SELF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then I can drag the db file to https://observablehq.com/@kindy/shotizam-viz and write sql there
:)