Skip to content

Commit

Permalink
Merge pull request Expensify#1636 from Expensify/andrew-version-bug
Browse files Browse the repository at this point in the history
Provide a default build version
  • Loading branch information
roryabraham authored Mar 4, 2021
2 parents 125b990 + c384cae commit d3fcab6
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .github/actions/bumpVersion/bumpVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ return octokit.repos.listTags({
.filter(tag => (tag.startsWith(currentPatchVersion)))
.map(tag => tag.split('-')[1])
),

// Provide a default of 0 for minimum build version
0,
);
console.log('Highest build number from current patch version:', highestBuildNumber);

Expand Down
3 changes: 3 additions & 0 deletions .github/actions/bumpVersion/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ return octokit.repos.listTags({
.filter(tag => (tag.startsWith(currentPatchVersion)))
.map(tag => tag.split('-')[1])
),

// Provide a default of 0 for minimum build version
0,
);
console.log('Highest build number from current patch version:', highestBuildNumber);

Expand Down
2 changes: 1 addition & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ android {
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1000001488
versionName "1.0.2--Infinity"
versionName "1.0.2-0"
}
splits {
abi {
Expand Down
2 changes: 1 addition & 1 deletion ios/ExpensifyCash/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.0.2.-Infinity</string>
<string>1.0.2.0</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/ExpensifyCashTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.0.2.-Infinity</string>
<string>1.0.2.0</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "expensify.cash",
"version": "1.0.2--Infinity",
"version": "1.0.2-0",
"author": "Expensify, Inc.",
"homepage": "https://expensify.cash",
"description": "Expensify.cash is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down

0 comments on commit d3fcab6

Please sign in to comment.