Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some french mistakes #338

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

QuentiumYT
Copy link

@QuentiumYT QuentiumYT commented Feb 27, 2025

Half a fix for #337, it does correct a few wrong things but I cannot find a way to satisfy both of these cases:
à partir de 03:00 and à partir de 3 du mois as "à partir" is only declared once in the methods.

The reason is in french, "à partir" is correlated by the subject, when it's a specific period (for example a day like monday or a month or a defined hour like 03:00), we say "à partir de".
When it's about a specific time / date (for example 3 january or "15" of the month), we say "à partir du".

As this project doesn't have something particular for any language, I kept "à partir de" as a general case, meaning à partir de 3 du mois is wrong.

@bradymholt
Copy link
Owner

Thanks! @QuentiumYT - would you be up for added these French tests as part of this PR?

@QuentiumYT
Copy link
Author

Oh sure, I thought it would only be for the fixes :) will commit some specific cases I added also. Will do that later thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants