Make deserialization faster (swc-project#324)

swc_ecma_ast: - make deserialization faster
brigand · Mar 8, 2019 · 248a53c · 248a53c
1 parent dd5f174
commit 248a53c
Show file tree

Hide file tree

Showing 9 changed files with 325 additions and 316 deletions.
diff --git a/.rustfmt.toml b/.rustfmt.toml
@@ -1,4 +1,4 @@
-required_version = "1.0.1"
+required_version = "1.0.3"
 use_field_init_shorthand = true
 merge_imports = true
 wrap_comments = true

diff --git a/ecmascript/ast/src/class.rs b/ecmascript/ast/src/class.rs
@@ -15,7 +15,6 @@ use swc_common::Fold;
 use swc_common::{ast_node, Span};
 
 #[ast_node]
-#[derive(Deserialize)]
 pub struct Class {
     #[serde(default)]
     pub span: Span,

diff --git a/ecmascript/ast/src/function.rs b/ecmascript/ast/src/function.rs
@@ -4,12 +4,10 @@ use crate::{
     stmt::BlockStmt,
     typescript::{TsParamProp, TsTypeAnn, TsTypeParamDecl},
 };
-use serde::Deserialize;
 use swc_common::{ast_node, Span};
 
 /// Common parts of function and method.
 #[ast_node]
-#[derive(Deserialize)]
 pub struct Function {
     pub params: Vec<Pat>,
 

diff --git a/ecmascript/parser/tests/test262.rs b/ecmascript/parser/tests/test262.rs
@@ -117,7 +117,7 @@ fn error_tests(tests: &mut Vec<TestDescAndFn>) -> Result<(), io::Error> {
 
     const TYPES: &[&str] = &[
         "fail", /* TODO
-                 * "early" */
+                * "early" */
     ];
 
     for err_type in TYPES {

diff --git a/ecmascript/transforms/src/compat/es2015/parameters/tests.rs b/ecmascript/transforms/src/compat/es2015/parameters/tests.rs
@@ -273,8 +273,7 @@ test!(
   {a6, a7} = {}) {}"#,
     "function fn(a1, param, param1, a5, param2) {
     var a2 = param === void 0 ? 4 : param, ref = param1 ? param1 : _throw(new TypeError(\"Cannot \
-     destructure 'undefined' or 'null'\")), a3 = ref.a3, a4 = ref.a4, ref1 = param2 === void 0 ? \
-     {
+     destructure 'undefined' or 'null'\")), a3 = ref.a3, a4 = ref.a4, ref1 = param2 === void 0 ? {
     } : param2, ref2 = ref1 ? ref1 : _throw(new TypeError(\"Cannot destructure 'undefined' or \
      'null'\")), a6 = ref2.a6, a7 = ref2.a7;
 }