fix(signals): restore lost store signals after SPA navigation
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
commented
May 26, 2024
| @@ -18,7 +18,7 @@ const pageWebComponents = { | |||
| }; | |||
|
|
|||
| const i18nCode = 3072; | |||
| const brisaSize = 5725; // TODO: Reduce this size | |||
| const brisaSize = 5732; // TODO: Reduce this size | |||
There was a problem hiding this comment.
We need to focus on the next iterations on reducing this size as much as possible...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208 bug.
This bug was introduced after SPA behavior. The problem is that the subscription was re-created again, without keeping the listeners that are still alive after browsing with SPA because the web components that are still alive in the same place are kept alive without disconnecting them.