Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): tabs layout for output section #493

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

enzonotario
Copy link
Collaborator

@enzonotario enzonotario commented Sep 29, 2024

Related #158

Adds tabs for Output section to switch between Web Component and Compiled Code.

Peek 2024-09-28 21-34

@enzonotario enzonotario changed the title feat(play-ground): tabs layout for output section feat(playground): tabs layout for output section Sep 29, 2024
@enzonotario
Copy link
Collaborator Author

@aralroca when I try to set automaticLayout: true option in packages/www/src/pages/playground/index.tsx:63, it loads successfully, but when I resize the window, I get the following:

image

I suspect it might be related to SSR, although it has skipSSR?

@aralroca
Copy link
Collaborator

aralroca commented Sep 29, 2024

@aralroca when I try to set automaticLayout: true option in packages/www/src/pages/playground/index.tsx:63, it loads successfully, but when I resize the window, I get the following:

image

I suspect it might be related to SSR, although it has skipSSR?

@enzonotario this error is displayed for the brisa-error-dialog in dev mode:

This happens because is catching all inside window.addEventListener('error', /* ... */). For some reason is not providing the correct error feedback. But this is the real error:

"ResizeObserver loop completed with undelivered notifications."

Screenshot 2024-09-29 at 09 43 51

I'm going to see what gives the correct error feedback in these cases, because otherwise it's very annoying to debug.

Copy link
Collaborator

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, it is already much better than before. I merge it and so we iterate. Good job!

@aralroca aralroca merged commit a7b4d53 into main Sep 29, 2024
3 of 6 checks passed
@aralroca aralroca deleted the feature/playground-changes branch September 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants