feat(deno): use Deno.serve
#659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brisa-adapter-vercel
brisa-pandacss
brisa
brisa-tailwindcss
www
create-brisa
commit: |
aralroca
force-pushed
the
aralroca/deno-serve
branch
from
2b87711 to
85be5b1
Compare
|
Unblocked by #668 💪🏽 |
aralroca
force-pushed
the
aralroca/deno-serve
branch
from
6c60168 to
e966098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #196
Awaiting this Deno issue denoland/deno#27223. At the moment Deno is currently working in the canary version of Brisa, however it uses the transformation of
http.IncomingMessagefrom Node toRequestand vice versa to return theResponse, which makes it slower than usingDeno.serve. This PR is an optimization, however, I have discovered a bug in Deno that has been reported, until it is not fixed we will not be able to use ReadableStream and it will be better to wait.