enable env browserbase for multi-region #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,6 @@ async def _create_session(self): | |||
| }, | |||
| } | |||
| ), | |||
| "proxies": True, | |||
There was a problem hiding this comment.
should this be a param?
There was a problem hiding this comment.
this is just the default config if none is passed
There was a problem hiding this comment.
it should go inside browserbase_session_create_params anyway
| and self.browserbase_session_create_params.get("region") | ||
| and self.browserbase_session_create_params.get("region") != "us-west-2" | ||
| ): | ||
| self.use_api = False |
filip-michalsky
approved these changes
Jun 16, 2025
|
maybe update .env.example to also remove ENVIRONMENT var? |
miguelg719
commented
Jun 16, 2025
stagehand/browser.py
Outdated
| connect_url = session.connectUrl | ||
| stagehand_instance.session_id = session.id |
miguelg719
commented
Jun 16, 2025
stagehand/config.py
Outdated
| @@ -96,6 +96,16 @@ class StagehandConfig(BaseModel): | |||
| alias="localBrowserLaunchOptions", | |||
| description="Local browser launch options", | |||
| ) | |||
| use_api: Optional[bool] = Field( | |||
| True, | |||
| alias="useAPI", | |||
miguelg719
commented
Jun 16, 2025
stagehand/config.py
Outdated
| ) | ||
| experimental: Optional[bool] = Field( | ||
| False, | ||
| alias="experimental", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
test plan