Fix logging #82
Merged
Fix logging #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STG-470 Fix logging
Local and BB logging differ, need to centralize and manage accordingly both formats |
| self.log(message, level=2, category=category, auxiliary=auxiliary) | ||
|
|
||
|
|
||
| def sync_log_handler(log_data: dict[str, Any]) -> None: |
There was a problem hiding this comment.
@miguelg719 do we need this since we have removed sync main.py/client.py?
There was a problem hiding this comment.
maybe not, it's just a parser function really we could probably optimize as a fast follow
There was a problem hiding this comment.
Sounds good, we can clean up later, not a blocker, pls merge when you think its g2g
filip-michalsky
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
test plan