Run CS fixer

bruno-ds · Feb 12, 2020 · 9071aa5 · 9071aa5
1 parent 4ef2310
commit 9071aa5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/Controller/RedirectToServiceController.php b/Controller/RedirectToServiceController.php
@@ -16,8 +16,8 @@
 use RuntimeException;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 /**
  * @author Alexander <[email protected]>
@@ -100,7 +100,6 @@ private function storeReturnPath(Request $request, string $authorizationUrl): vo
             $sessionKeyFailure = '_security.'.$providerKey.'.failed_target_path';
 
             if (!empty($param) && $targetUrl = $request->get($param)) {
-
                 if (!$this->domainWhitelist->isValidTargetUrl($targetUrl)) {
                     throw new AccessDeniedHttpException('Not allowed to redirect to '.$targetUrl);
                 }

diff --git a/Tests/Controller/RedirectToServiceControllerTest.php b/Tests/Controller/RedirectToServiceControllerTest.php
@@ -58,7 +58,6 @@ protected function setUp(): void
         $this->oAuthUtils = $this->createMock(OAuthUtils::class);
         $this->domainsWhiteList = $this->createMock(DomainWhitelist::class);
 
-
         $this->session = $this->createMock(SessionInterface::class);
         $this->request = Request::create('/');
         $this->request->setSession($this->session);

diff --git a/Tests/Util/DomainWhitelistTest.php b/Tests/Util/DomainWhitelistTest.php
@@ -11,17 +11,17 @@
 
 namespace HWI\Bundle\OAuthBundle\Tests\Util;
 
-use PHPUnit\Framework\TestCase;
 use HWI\Bundle\OAuthBundle\Util\DomainWhitelist;
+use PHPUnit\Framework\TestCase;
 
 class DomainWhitelistTest extends TestCase
 {
     /**
      * @dataProvider targetUrlProvider
      *
      * @param string $targetUrl
-     * @param array $domainsWhitelistParameter
-     * @param bool $isValidTargetUrl
+     * @param array  $domainsWhitelistParameter
+     * @param bool   $isValidTargetUrl
      */
     public function testValidateTargetUrl($targetUrl, $domainsWhitelistParameter, $isValidTargetUrl)
     {
@@ -38,4 +38,4 @@ public function targetUrlProvider()
             ['https://example.com/redirect', ['foobar.com', 'example.com'], true],
         ];
     }
-}
+}
diff --git a/Util/DomainWhitelist.php b/Util/DomainWhitelist.php
@@ -31,11 +31,12 @@ public function __construct(array $targetPathDomainsWhiteList)
 
     /**
      * @param string $targetUrl
+     *
      * @return bool
      */
     public function isValidTargetUrl(string $targetUrl)
     {
-        if (0 === count($this->targetPathDomainsWhiteList)) {
+        if (0 === \count($this->targetPathDomainsWhiteList)) {
             return true;
         }
 
@@ -44,10 +45,10 @@ public function isValidTargetUrl(string $targetUrl)
             return false;
         }
 
-        if (!in_array($urlParts['host'], $this->targetPathDomainsWhiteList, true)) {
+        if (!\in_array($urlParts['host'], $this->targetPathDomainsWhiteList, true)) {
             return false;
         }
 
         return true;
     }
-}
+}