Merge pull request hwi#1627 from AntoineLemaire/azure-names

Add first_name & last_name in AzureResourceOwner
bruno-ds · May 7, 2020 · de6566a · de6566a
2 parents 6e7dbf9 + dce2bd9
commit de6566a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/OAuth/ResourceOwner/AzureResourceOwner.php b/OAuth/ResourceOwner/AzureResourceOwner.php
@@ -26,6 +26,8 @@ class AzureResourceOwner extends GenericOAuth2ResourceOwner
     protected $paths = [
         'identifier' => 'sub',
         'nickname' => 'unique_name',
+        'lastname' => 'family_name',
+        'firstname' => 'given_name',
         'realname' => ['given_name', 'family_name'],
         'email' => ['upn', 'email'],
         'profilepicture' => null,

diff --git a/Tests/OAuth/ResourceOwner/AzureResourceOwnerTest.php b/Tests/OAuth/ResourceOwner/AzureResourceOwnerTest.php
@@ -64,6 +64,8 @@ public function testGetUserInformation()
 
         $this->assertEquals('1', $userResponse->getUsername());
         $this->assertEquals('Dummy Tester', $userResponse->getRealName());
+        $this->assertEquals('Dummy', $userResponse->getFirstName());
+        $this->assertEquals('Tester', $userResponse->getLastName());
         $this->assertEquals('dummy123', $userResponse->getNickname());
         $this->assertNull($userResponse->getRefreshToken());
         $this->assertNull($userResponse->getExpiresIn());
@@ -87,6 +89,8 @@ public function testCustomResponseClass()
         $this->assertInstanceOf($class, $userResponse);
         $this->assertEquals('foo666', $userResponse->getUsername());
         $this->assertEquals('foo', $userResponse->getNickname());
+        $this->assertEquals('foo', $userResponse->getFirstName());
+        $this->assertEquals('BAR', $userResponse->getLastName());
         $this->assertEquals('token', $userResponse->getAccessToken());
         $this->assertNull($userResponse->getRefreshToken());
         $this->assertNull($userResponse->getExpiresIn());