Fix string comarison with pathname error (rails#72)

* Fix comparison with pathname issue * Map to string on the array * Ensure one of the paths for test is a string Co-authored-by: David Heinemeier Hansson <[email protected]> Co-authored-by: David Heinemeier Hansson <[email protected]>
brunoprietog · Feb 19, 2022 · 7f724d1 · 7f724d1
1 parent f953dce
commit 7f724d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/propshaft/load_path.rb b/lib/propshaft/load_path.rb
@@ -68,8 +68,8 @@ def clear_cache
 
     def dedup(paths)
       [].tap do |deduped|
-        Array(paths).sort.each do |path|
-          deduped << Pathname.new(path) if deduped.blank? || !path.to_s.start_with?(deduped.last.to_s)
+        Array(paths).map(&:to_s).sort.each do |path|
+          deduped << Pathname.new(path) if deduped.blank? || !path.start_with?(deduped.last.to_s)
         end
       end
     end

diff --git a/test/propshaft/load_path_test.rb b/test/propshaft/load_path_test.rb
@@ -5,7 +5,7 @@ class Propshaft::LoadPathTest < ActiveSupport::TestCase
   setup do
     @load_path = Propshaft::LoadPath.new [
       Pathname.new("#{__dir__}/../fixtures/assets/first_path"),
-      Pathname.new("#{__dir__}/../fixtures/assets/second_path")
+      Pathname.new("#{__dir__}/../fixtures/assets/second_path").to_s
     ]
   end