syntax: improve error message for unmatched close paren (google#74)

Fixes google#48
bryanchance · Dec 17, 2018 · 990a796 · 990a796
1 parent f817a90
commit 990a796
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/syntax/scan.go b/syntax/scan.go
@@ -618,7 +618,7 @@ start:
 
 	case ']', ')', '}':
 		if sc.depth == 0 {
-			sc.error(sc.pos, "indentation error")
+			sc.errorf(sc.pos, "unexpected %q", c)
 		} else {
 			sc.depth--
 		}

diff --git a/syntax/testdata/errors.star b/syntax/testdata/errors.star
@@ -204,3 +204,7 @@ c, d = 1, 2 # ok
 a, b, = 1, 2 ### `unparenthesized tuple with trailing comma`
 ---
 a, b = 1, 2, ### `unparenthesized tuple with trailing comma`
+
+---
+# See github.com/google/starlark-go/issues/48
+a = max(range(10))) ### `unexpected '\)'`