Tags: bryango/nix
Tags
fetchers/git: make path absolute for local repo
fetchers/git: make path absolute for local repo
libutil/url: fix git+file:./ parse error Previously, the "file:./" prefix was not correctly recognized in fixGitURL; instead, it was mistaken as a file path, which resulted in a parsed url of the form "file://file:./". This commit fixes the issue by properly detecting the "file:" prefix. Note, however, that unlike "file://", the "file:./" URI is _not_ standardized, but has been widely used to referred to relative file paths. In particular, the "git+file:./" did work for nix<=2.18, and was broekn since nix 2.19.0. Finally, this commit fixes the issue completely for the 2.19 series, but is still inadequate for the 2.20 series due to new behaviors from the switch to libgit2. However, it does improve the correctness of parsing even though it is not yet a complete solution.
libutil/url: fix git+file:./ parse error Previously, the "file:./" prefix was not correctly recognized in fixGitURL; instead, it was mistaken as a file path, which resulted in a parsed url of the form "file://file:./". This commit fixes the issue by properly detecting the "file:" prefix. Note, however, that unlike "file://", the "file:./" URI is _not_ standardized, but is widely used to referred to relative file paths. In particular, the "git+file:./" did work for nix<=2.18, and was broken in nix 2.19.0. A test is added to "tests/functional/fetchGit.sh" to prevent future breakage.
libutil/url: fix git+file:./ parse error Previously, the "file:./" prefix was not correctly recognized in fixGitURL; instead, it was mistaken as a file path, which resulted in a parsed url of the form "file://file:./". This commit fixes the issue by properly detecting the "file:" prefix. Note, however, that unlike "file://", the "file:./" URI is _not_ standardized, but is widely used to referred to relative file paths. In particular, the "git+file:./" did work for nix<=2.18, and was broken in nix 2.19.0. A test is added to "tests/functional/fetchGit.sh" to prevent future breakage.
libutil/url: fix git+file:./ parse error Previously, the "file:./" prefix was not correctly recognized in fixGitURL; instead, it was mistaken as a file path, which resulted in a parsed url of the form "file://file:./". This commit fixes the issue by properly detecting the "file:" prefix. Note, however, that unlike "file://", the "file:./" URI is _not_ standardized, but is widely used to referred to relative file paths. In particular, the "git+file:./" did work for nix<=2.18, and was broken in nix 2.19.0. A test is added to "tests/functional/fetchGit.sh" to prevent future breakage.
libutil/url: fix git+file:./ parse error Previously, the "file:./" prefix was not correctly recognized in fixGitURL; instead, it was mistaken as a file path, which resulted in a parsed url of the form "file://file:./". This commit fixes the issue by properly detecting the "file:" prefix. Note, however, that unlike "file://", the "file:./" URI is _not_ standardized, but is widely used to referred to relative file paths. In particular, the "git+file:./" did work for nix<=2.18, and was broken in nix 2.19.0. A test is added to "tests/functional/fetchGit.sh" to prevent future breakage.
libutil/url: fix file:./ parse error in fixGitURL Previously, the "file:./" prefix was not correctly recognized; instead, it was mistaken as a file path, which resulted in a parsed url of the form "file://file:./". This is fixed in this commit by properly detecting the "file:" prefix.