Skip to content

Callbacks 1 and 2 complete #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Callbacks 1 and 2 complete #1

wants to merge 9 commits into from

Conversation

bryanszendel
Copy link
Owner

No description provided.

@bryanszendel bryanszendel requested a review from seanwu20-zz June 11, 2019 20:29
Copy link

@seanwu20-zz seanwu20-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on MVP! A lot of array methods like map and filter already create a new array, so there's no need to make a separate array.

let allCaps = [];
allCaps = runners.map(item => item['first_name'].toUpperCase());

This can be simplified to
let allCaps = runners.map(item => item['first_name'].toUpperCase());

Score: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants