Fixed possible issues when cloning a course containing a quiz built w…

…ith the Advanced Quizzes addon, after disabling it

.changelogs/fix-clone-advanced-quizzes.yml

@@ -0,0 +1,4 @@
+significance: patch
+type: fixed
+entry: Fixed possible issues when cloning a course containing a quiz built with
+  the Advanced Quizzes addon, after disabling it.

includes/models/model.llms.question.choice.php

@@ -5,7 +5,7 @@
  * @package LifterLMS/Models/Classes
  *
  * @since 3.16.0
- * @version 3.16.0
+ * @version [version]
  */
 
 defined( 'ABSPATH' ) || exit;
@@ -216,13 +216,14 @@ public function save() {
 	}
 
 	/**
-	 * Set a piece of data by key
+	 * Set a piece of data by key.
 	 *
-	 * @param    string $key  name of the key to set
-	 * @param    mixed  $val  value to set
-	 * @return   self
-	 * @since    3.16.0
-	 * @version  3.16.0
+	 * @since 3.16.0
+	 * @since [version] Check `$type['choices']` is an array before trying to access it as such.
+	 *
+	 * @param string $key Name of the key to set.
+	 * @param mixed  $val Value to set.
+	 * @return self
 	 */
 	public function set( $key, $val ) {
 
@@ -244,10 +245,12 @@ public function set( $key, $val ) {
 				break;
 
 			case 'marker':
-				$type    = $this->get_question()->get_question_type();
-				$markers = $type['choices']['markers'];
-				if ( ! in_array( $val, $markers ) ) {
-					$val = $markers[0];
+				$type = $this->get_question()->get_question_type();
+				if ( is_array( $type['choices'] ?? false ) ) {
+					$markers = $type['choices']['markers'];
+					if ( ! in_array( $val, $markers ) ) {
+						$val = $markers[0];
+					}
 				}
 				break;
 

includes/models/model.llms.question.php

@@ -5,7 +5,7 @@
  * @package LifterLMS/Models/Classes
  *
  * @since 1.0.0
- * @version 4.4.0
+ * @version [version]
  */
 
 defined( 'ABSPATH' ) || exit;
@@ -407,17 +407,21 @@ public function get_image( $size = 'full', $unused = null ) {
 	}
 
 	/**
-	 * Retrieve the next marker for question choices
+	 * Retrieve the next marker for question choices.
 	 *
 	 * @since 3.16.0
 	 * @since 3.30.1 Fixed bug which caused the next marker to be 1 index too high.
+	 * @since [version] Check `$type['choices']` is an array before trying to access it as such.
 	 *
 	 * @return string
 	 */
 	protected function get_next_choice_marker() {
 		$next_index = count( $this->get_choices( 'ids', false ) );
 		$type       = $this->get_question_type();
-		$markers    = $type['choices']['markers'];
+		if ( ! is_array( $type['choices'] ?? false ) ) {
+			return false;
+		}
+		$markers = $type['choices']['markers'];
 		return $next_index > count( $markers ) ? false : $markers[ $next_index ];
 	}