Fixed nightwatchjs#438 - an issue with passing a numeric tag

bstenm · May 14, 2015 · c040ccd · c040ccd
1 parent c4289e6
commit c040ccd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/lib/runner/filematcher.js b/lib/runner/filematcher.js
@@ -51,7 +51,7 @@ module.exports = {
     checkModuleTags: function (test, tags) {
       var testTags = test['@tags'] || test.tags;
 
-      if (typeof tags === 'string') {
+      if (!Array.isArray(tags)) {
         tags = [tags];
       }
 

diff --git a/lib/runner/testcase.js b/lib/runner/testcase.js
@@ -55,7 +55,6 @@ TestCase.prototype.run = function () {
       };
 
       self.suite.client.once('complete', function(results, errors) {
-        console.log('COMPLETE', results)
         self.results = results;
         self.errors = errors;
         if (self.suite.client.options.start_session) {
@@ -105,7 +104,6 @@ TestCase.prototype.run = function () {
       return deferredNext.promise;
     })
     .then(function onSuccess(response) {
-      console.log('onSuccess', response)
       self.results = response.results;
       self.errors = response.errors;
 

diff --git a/tests/src/runner/testFileMatcher.js b/tests/src/runner/testFileMatcher.js
@@ -56,4 +56,15 @@ module.exports = {
     test.ok(matched === true);
     test.done();
   },
+
+  'tag: test matching numeric tags single': function (test) {
+    var tags = 101;
+    var testModule = {
+      tags: ['101']
+    };
+
+    var matched = matcher.tags.checkModuleTags(testModule, tags);
+    test.ok(matched === true);
+    test.done();
+  }
 };