Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Upgrades dependencies and fixes the dd-trace interface #17

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

dinostheo
Copy link
Member

NOTE: This upgrade introduces breaking changes in the library; therefore, a major version upgrade is required (1.0.0).

It upgrades the dd-trace and adapts the TracerOptions based on that version. DD_TRACING_ENABLED does not have an option in the configuration and is used by the environment variable. The default value is true.
https://docs.datadoghq.com/tracing/trace_collection/library_config/nodejs/#instrumentation

It also upgrades other development dependencies to a version that fixes security vulnerabilities.

@dinostheo dinostheo requested review from philippemiguet and a team July 22, 2024 21:20
@dinostheo dinostheo self-assigned this Jul 22, 2024
Copy link
Contributor

@philippemiguet philippemiguet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve due to Core being on Node 14

"@bufferapp/bufflog": "0.3.1",
"dd-trace": "1.4.1",
"@bufferapp/bufflog": "0.5.1",
"dd-trace": "^5.18.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dinostheo, I believe we cannot do this upgrade for now because Core services are still running on Node 14.

It is mentioned in the changelog at version 4.

For the other breaking changes, I think we are good. For the new env variables, please make sure all services in buffer-mono does have it as well 😊

The infra team has the goal to migrated Core services to node 20 this quarter, so you will want to coordinate with them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philippemiguet, I didn't consider that we were still using v14.

@dinostheo dinostheo requested review from kiriappeee and hamstu August 13, 2024 14:33
@dinostheo
Copy link
Member Author

@philippemiguet @kiriappeee @hamstu
I bumped the version to a new major v1 and planning to publish this package.
The services that run in an older Node.js version than version 18, will need to upgrade before using the latest version of this package.
In this way, we can start modifying the rest of the services.

@dinostheo dinostheo merged commit 368bbc1 into main Aug 14, 2024
@dinostheo dinostheo deleted the upgrade-dependencies branch August 14, 2024 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants