Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the unity performance library to the test fixture #892

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

richardelms
Copy link
Contributor

@richardelms richardelms commented Mar 7, 2025

NOTE: REQUIRES PERFORMANCE RELEASE BEFORE MERGING

Goal

add the unity performance library to the test fixture so that we have more coverage and are more likely to detect breaking changes between both libs.

Changeset

  • add the latest performance release to the fixture on build.
  • updated the PlayerSettingsCompat class to have a more specific unity version check.
  • added the PlayerSettingsCompat class to the fixture so it can also set UNITY_ASSERTIONS scripting symbol.

Testing

Covered by E2E tests

@richardelms richardelms self-assigned this Mar 7, 2025
@bugsnagbot
Copy link
Collaborator

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2631.62
IL2CPP IPA 1746.55

Generated by 🚫 Danger

Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants