Non-functional code-style fixes

src/DurableTask.AzureStorage/BackoffPollingHelper.cs

@@ -48,12 +48,12 @@ class RandomizedExponentialBackoffStrategy
         {
             public const double RandomizationFactor = 0.2;
 
-            private readonly TimeSpan minimumInterval;
-            private readonly TimeSpan maximumInterval;
-            private readonly TimeSpan deltaBackoff;
+            readonly TimeSpan minimumInterval;
+            readonly TimeSpan maximumInterval;
+            readonly TimeSpan deltaBackoff;
 
-            private uint backoffExponent;
-            private Random random;
+            uint backoffExponent;
+            Random random;
 
             public RandomizedExponentialBackoffStrategy(TimeSpan minimumInterval, TimeSpan maximumInterval)
                 : this(minimumInterval, maximumInterval, minimumInterval)

src/DurableTask.AzureStorage/PurgeHistoryResult.cs

@@ -0,0 +1,49 @@
+//  ----------------------------------------------------------------------------------
+//  Copyright Microsoft Corporation
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//  http://www.apache.org/licenses/LICENSE-2.0
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+//  ----------------------------------------------------------------------------------
+
+namespace DurableTask.AzureStorage
+{
+    /// <summary>
+    /// Class to hold statistics about this execution of purge history
+    /// </summary>
+    public class PurgeHistoryResult
+    {
+        /// <summary>
+        /// Constructor for purge history statistics
+        /// </summary>
+        /// <param name="storageRequests">Requests sent to storage</param>
+        /// <param name="instancesDeleted">Number of instances deleted</param>
+        /// <param name="rowsDeleted">Number of rows deleted</param>
+        public PurgeHistoryResult(int storageRequests, int instancesDeleted, int rowsDeleted)
+        {
+            this.StorageRequests = storageRequests;
+            this.InstancesDeleted = instancesDeleted;
+            this.RowsDeleted = rowsDeleted;
+        }
+
+        /// <summary>
+        /// Number of requests sent to Storage during this execution of purge history
+        /// </summary>
+        public int StorageRequests { get; }
+
+        /// <summary>
+        /// Number of instances deleted during this execution of purge history
+        /// </summary>
+        public int InstancesDeleted { get; }
+
+        /// <summary>
+        /// Number of rows deleted during this execution of purge history
+        /// </summary>
+        public int RowsDeleted { get; }
+    }
+}

src/DurableTask.AzureStorage/Tracking/AzureTableTrackingStore.cs

@@ -31,7 +31,7 @@ namespace DurableTask.AzureStorage.Tracking
     using Newtonsoft.Json;
 
     /// <summary>
-    /// Tracking store for use with the AzureStorageOrxhestration Service. Uses azure table and blob storage to store runtime state.
+    /// Tracking store for use with <see cref="AzureStorageOrchestrationService"/>. Uses Azure Tables and Azure Blobs to store runtime state.
     /// </summary>
     class AzureTableTrackingStore : TrackingStoreBase
     {
@@ -269,7 +269,7 @@ public override async Task<bool> ExistsAsync()
             };
         }
 
-        private async Task<List<DynamicTableEntity>> QueryHistoryAsync(string filterCondition, string instanceId, CancellationToken cancellationToken)
+        async Task<List<DynamicTableEntity>> QueryHistoryAsync(string filterCondition, string instanceId, CancellationToken cancellationToken)
         {
             TableQuery query = new TableQuery().Where(filterCondition.ToString());
 
@@ -490,7 +490,7 @@ public override async Task<OrchestrationState> GetStateAsync(string instanceId,
             return this.ConvertFromAsync(orchestrationInstanceStatus, instanceId);
         }
 
-        private OrchestrationState ConvertFromAsync(OrchestrationInstanceStatus orchestrationInstanceStatus, string instanceId)
+        OrchestrationState ConvertFromAsync(OrchestrationInstanceStatus orchestrationInstanceStatus, string instanceId)
         {
             var orchestrationState = new OrchestrationState();
             if (!Enum.TryParse(orchestrationInstanceStatus.RuntimeStatus, out orchestrationState.OrchestrationStatus))
@@ -539,7 +539,7 @@ private OrchestrationState ConvertFromAsync(OrchestrationInstanceStatus orchestr
                 cancellationToken);
         }
 
-        private async Task<DurableStatusQueryResult> QueryStateAsync(TableQuery<OrchestrationInstanceStatus> query, int top, string continuationToken, CancellationToken cancellationToken)
+        async Task<DurableStatusQueryResult> QueryStateAsync(TableQuery<OrchestrationInstanceStatus> query, int top, string continuationToken, CancellationToken cancellationToken)
         {
             TableContinuationToken token = null;
             var orchestrationStates = new List<OrchestrationState>(top);
@@ -566,7 +566,7 @@ private async Task<DurableStatusQueryResult> QueryStateAsync(TableQuery<Orchestr
             };
         }
 
-        private async Task<IList<OrchestrationState>> QueryStateAsync(TableQuery<OrchestrationInstanceStatus> query, CancellationToken cancellationToken)
+        async Task<IList<OrchestrationState>> QueryStateAsync(TableQuery<OrchestrationInstanceStatus> query, CancellationToken cancellationToken)
         {
             TableContinuationToken token = null;
             var orchestrationStates = new List<OrchestrationState>(100);
@@ -593,7 +593,7 @@ private async Task<IList<OrchestrationState>> QueryStateAsync(TableQuery<Orchest
             return orchestrationStates;
         }
 
-        private async Task<PurgeHistoryResult> DeleteHistoryAsync(DateTime createdTimeFrom, DateTime? createdTimeTo, IEnumerable<OrchestrationStatus> runtimeStatus)
+        async Task<PurgeHistoryResult> DeleteHistoryAsync(DateTime createdTimeFrom, DateTime? createdTimeTo, IEnumerable<OrchestrationStatus> runtimeStatus)
         {
             TableQuery<OrchestrationInstanceStatus> query = OrchestrationInstanceStatusQueryCondition.Parse(createdTimeFrom, createdTimeTo, runtimeStatus)
                 .ToTableQuery<OrchestrationInstanceStatus>();
@@ -630,7 +630,7 @@ private async Task<PurgeHistoryResult> DeleteHistoryAsync(DateTime createdTimeFr
             return new PurgeHistoryResult(storageRequests, instancesDeleted, rowsDeleted);
         }
 
-        private async Task<PurgeHistoryResult> DeleteAllDataForOrchestrationInstance(OrchestrationInstanceStatus orchestrationInstanceStatus)
+        async Task<PurgeHistoryResult> DeleteAllDataForOrchestrationInstance(OrchestrationInstanceStatus orchestrationInstanceStatus)
         {
             int storageRequests = 0;
             int rowsDeleted = 0;

src/DurableTask.AzureStorage/Tracking/OrchestrationInstanceStatusQueryCondition.cs

@@ -13,18 +13,16 @@
 
 namespace DurableTask.AzureStorage.Tracking
 {
-    using DurableTask.Core;
-    using Microsoft.WindowsAzure.Storage.Table;
     using System;
     using System.Collections.Generic;
     using System.Linq;
-    using System.Text;
-    using System.Xml.Linq;
+    using DurableTask.Core;
+    using Microsoft.WindowsAzure.Storage.Table;
 
     /// <summary>
     /// OrchestrationInstanceStatusQueryBuilder is a builder to create a StorageTable Query
     /// </summary>
-    internal class OrchestrationInstanceStatusQueryCondition
+    class OrchestrationInstanceStatusQueryCondition
     {
         public IEnumerable<OrchestrationStatus> RuntimeStatus { get; set; }
 
@@ -45,7 +43,7 @@ public TableQuery<T> ToTableQuery<T>()
             return query;
         }
 
-        private string GetConditions()
+        string GetConditions()
         {
             var conditions = new List<string>();
 
@@ -72,7 +70,6 @@ private string GetConditions()
             return conditions.Count == 1 ? 
                 conditions[0] : 
                 conditions.Aggregate((a, b) => TableQuery.CombineFilters(a, TableOperators.And, b));
-
         }
 
         /// <summary>

src/DurableTask.AzureStorage/Utils.cs

@@ -84,38 +84,4 @@ public static int GetEpisodeNumber(IEnumerable<HistoryEvent> historyEvents)
             return historyEvents.Count(e => e.EventType == EventType.OrchestratorStarted);
         }
     }
-
-    /// <summary>
-    /// Class to hold statistics about this execution of purge history
-    /// </summary>
-    public class PurgeHistoryResult
-    {
-        /// <summary>
-        /// Constructor for purge history statistics
-        /// </summary>
-        /// <param name="storageRequests">Requests sent to storage</param>
-        /// <param name="instancesDeleted">Number of instances deleted</param>
-        /// <param name="rowsDeleted">Number of rows deleted</param>
-        public PurgeHistoryResult(int storageRequests, int instancesDeleted, int rowsDeleted)
-        {
-            this.StorageRequests = storageRequests;
-            this.InstancesDeleted = instancesDeleted;
-            this.RowsDeleted = rowsDeleted;
-        }
-
-        /// <summary>
-        /// Number of requests sent to Storage during this execution of purge history
-        /// </summary>
-        public int StorageRequests { get; }
-
-        /// <summary>
-        /// Number of instances deleted during this execution of purge history
-        /// </summary>
-        public int InstancesDeleted { get; }
-
-        /// <summary>
-        /// Number of rows deleted during this execution of purge history
-        /// </summary>
-        public int RowsDeleted { get; }
-    }
 }