Skip to content

Commit

Permalink
ruby/phone-number: Phone -> PhoneNumber
Browse files Browse the repository at this point in the history
More appropriate name for the class. Maybe USPhoneNumber would be better still.
  • Loading branch information
henrik committed Sep 8, 2013
1 parent ad0dfe4 commit 52af846
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion assignments/ruby/phone-number/example.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class Phone
class PhoneNumber

attr_reader :number
def initialize(number)
Expand Down
20 changes: 10 additions & 10 deletions assignments/ruby/phone-number/phone-number_test.rb
Original file line number Diff line number Diff line change
@@ -1,52 +1,52 @@
require 'minitest/autorun'
require_relative 'phone'
require_relative 'phone_number'

class PhoneTest < MiniTest::Unit::TestCase
class PhoneNumberTest < MiniTest::Unit::TestCase

def test_cleans_number
number = Phone.new("(123) 456-7890").number
number = PhoneNumber.new("(123) 456-7890").number
assert_equal "1234567890", number
end

def test_cleans_number_with_dots
skip
number = Phone.new("123.456.7890").number
number = PhoneNumber.new("123.456.7890").number
assert_equal "1234567890", number
end

def test_valid_when_11_digits_and_first_is_1
skip
number = Phone.new("11234567890").number
number = PhoneNumber.new("11234567890").number
assert_equal "1234567890", number
end

def test_invalid_when_11_digits
skip
number = Phone.new("21234567890").number
number = PhoneNumber.new("21234567890").number
assert_equal "0000000000", number
end

def test_invalid_when_9_digits
skip
number = Phone.new("123456789").number
number = PhoneNumber.new("123456789").number
assert_equal "0000000000", number
end

def test_area_code
skip
number = Phone.new("1234567890")
number = PhoneNumber.new("1234567890")
assert_equal "123", number.area_code
end

def test_pretty_print
skip
number = Phone.new("1234567890")
number = PhoneNumber.new("1234567890")
assert_equal "(123) 456-7890", number.to_s
end

def test_pretty_print_with_full_us_phone_number
skip
number = Phone.new("11234567890")
number = PhoneNumber.new("11234567890")
assert_equal "(123) 456-7890", number.to_s
end

Expand Down

0 comments on commit 52af846

Please sign in to comment.