chore(dev): exit when using fake built ins (remix-run#321)

bxt · Oct 22, 2021 · 1ad266c · 1ad266c
1 parent fdebb4a
commit 1ad266c
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/packages/remix-dev/compiler.ts b/packages/remix-dev/compiler.ts
@@ -259,6 +259,16 @@ async function createBrowserBuild(
   // on node built-ins in browser bundles.
   let dependencies = Object.keys(await getAppDependencies(config));
   let externals = nodeBuiltins.filter(mod => !dependencies.includes(mod));
+  let fakeBuiltins = nodeBuiltins.filter(mod => dependencies.includes(mod));
+
+  if (fakeBuiltins.length > 0) {
+    console.error(
+      `It appears you're using a module that is built in to node, but you installed it as a dependency which could cause problems. Please remove ${fakeBuiltins.join(
+        ", "
+      )} before continuing.`
+    );
+    process.exit(1);
+  }
 
   let entryPoints: esbuild.BuildOptions["entryPoints"] = {
     "entry.client": path.resolve(config.appDirectory, config.entryClientFile)