put the happy path first

bytectl · Nov 27, 2022 · 28bb370 · 28bb370
1 parent 70a91fd
commit 28bb370
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/transport.go b/transport.go
@@ -68,10 +68,11 @@ func (t *Transport) save(res *http.Response) error {
 	//       to match against outgoing requests. We're currently ignoring
 	//       it and just matching the hostname.
 	host := res.Request.URL.Hostname()
-	if err != nil {
-		delete(t.cache, host)
-	} else {
+	if err == nil {
 		t.cache[host] = &cchal{c: chal}
+	} else {
+		// if save is being invoked, the existing cached challenge didn't work
+		delete(t.cache, host)
 	}
 	t.cacheMu.Unlock()
 	return err