Skip to content

Commit

Permalink
Fix: Contributor image that was a different size from the others. (Th…
Browse files Browse the repository at this point in the history
…eOdinProject#3709)

<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
This solves issue with Ryan's contributor image having a different size
from the others as shown in the [comment to
PR#3707.](TheOdinProject#3707 (comment))

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
- Added Ryan's Image to repo
- Changed source of image from Ryan's GitHub profile picture to the repo
folder
- Updated Ryan's GitHub URL from old URL to the new one
- All other changes mentioned in TheOdinProject#3707 

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes TheOdinProject#2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
TheOdinProject#2013'.
-->
Closes TheOdinProject#3662

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->
Initial PR: TheOdinProject#3707 

## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
  - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
  - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [x] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
  • Loading branch information
jasonisrailov authored Apr 1, 2023
1 parent 99cf61d commit dae0fbe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Binary file added app/assets/images/hall_of_fame_images/ryan.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/views/static_pages/contributing/_hall_of_fame.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<% members.each do |member| %>
<div class="col-span-4 sm:col-span-3 md:col-span-2">
<%= link_to(member[:github_url], target: '_blank', rel: 'noreferrer') do %>
<%= image_tag(member[:image], alt: member[:name], class: 'h-full') %>
<%= image_tag(member[:image], alt: member[:name]) %>
<% end %>
</div>
<% end %>
Expand Down
4 changes: 2 additions & 2 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ en:
image: https://avatars1.githubusercontent.com/u/20132181?v=3&s=400
github_url: https://github.com/RobPando
- name: Ryan
image: https://avatars3.githubusercontent.com/u/20901017?v=3&s=400
github_url: https://github.com/ryanford-frontend
image: hall_of_fame_images/ryan.jpg
github_url: https://github.com/ryanford
faq:
items:
- question: 'Who is The Odin Project for?'
Expand Down

0 comments on commit dae0fbe

Please sign in to comment.