Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: event recurring web wrapper #16764

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Sep 23, 2024

What does this PR do?

  • Introduced a new EventRecurringWebWrapper component to centralize all TRPC endpoint calls, improving data handling and separation of concerns.
  • Refactored the existing EventRecurringTab into a presentational (dumb) component, shifting all TRPC calls and logic to the newly created parent wrapper (EventAvailabilityTabWebWrapper). It now solely handles UI rendering, receiving data and callbacks as props from its parent.
  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team September 23, 2024 07:45
Copy link

graphite-app bot commented Sep 23, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (09/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 23, 2024
@graphite-app graphite-app bot requested a review from a team September 23, 2024 07:45
@dosubot dosubot bot added event-types area: event types, event-types 💻 refactor labels Sep 23, 2024
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 7:53am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 7:53am

Copy link
Contributor

github-actions bot commented Sep 24, 2024

E2E results are ready!

@SomayChauhan SomayChauhan enabled auto-merge (squash) September 30, 2024 07:53
@SomayChauhan SomayChauhan merged commit 8431cd2 into main Sep 30, 2024
37 checks passed
@SomayChauhan SomayChauhan deleted the event-recurring-web-wrapper branch September 30, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only event-types area: event types, event-types platform Anything related to our platform plan ready-for-e2e 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants