Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Huddle01 App Flow #16907

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

feat: Updated Huddle01 App Flow #16907

wants to merge 46 commits into from

Conversation

ponikar
Copy link

@ponikar ponikar commented Oct 2, 2024

What does this PR do?

  • We at Huddle01 have revamped several things, including how users interact and communicate through the Huddle01 app. Huddle01 now has a dedicated OAuth mechanism that empowers third-party applications like CalCom. To make CalCom compatible with the new flow, we have rewritten the current app.
  • Introduced an Authentication page to allow users to confirm their identity before scheduling a call.
  • Added Huddle01 OAuth support that works independently.
  • Introduced a new set of APIs to communicate with Huddle01 servers.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Once you install a fresh Huddle01 app, you are required to confirm your identity via login to the Huddle01 auth page.

  • Once the authentication process succeeds, you can configure your events to use the Huddle01 app to schedule meetings when users make bookings.

  • Now, while booking a call, the user should see the Huddle01 app to book the call.

  • API calls should work, and the user should see the meeting link after the booking is made.

  • Test modify and cancel flows; we have added separate API calls corresponding to each functionality.

  • On the booking pages, meeting details should be visible.

  • Are there environment variables that should be set?

    • Yes, we have a new HUDDLE01_API_TOKEN to handle the authentication process. It needs to be set.
  • What are the minimal test data requirements?

    • Huddle01 account to test authentication.
  • What is expected (happy path) to have (input and output)?

    • Install the Huddle01 app and complete the authentication process.
    • Configure your events to use the Huddle01 app for scheduling meetings.
    • Users should be able to schedule, modify, and cancel the meeting.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project.
  • I haven't commented my code, particularly in hard-to-understand areas.
  • I haven't checked if my changes generate no new warnings.

@ponikar ponikar marked this pull request as ready for review October 2, 2024 12:41
@graphite-app graphite-app bot requested review from a team October 2, 2024 12:41
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 2, 2024
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in ✨ feature New feature or request labels Oct 2, 2024
Copy link

graphite-app bot commented Oct 2, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/02/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ponikar, can you please uncommit the lock file? I don't think it's need to update for the current changes.

@anikdhabal
Copy link
Contributor

Thanks @ponikar , Could you also please add a README to explain the process of obtaining the Huddle API token? Like this:- https://github.com/calcom/cal.com/blob/main/packages/app-store/webex/README.md

@ponikar
Copy link
Author

ponikar commented Oct 3, 2024

Hey @ponikar, can you please uncommit the lock file? I don't think it's need to update for the current changes.

Hey @anikdhabal
We don't provide third party authentication publicly as of now. We have internal APIs to create token to identify Calcom internally. It shouldn't affect calcom users to any other ways.

If anyone requires to generate a similar token they can reach out to [email protected]

Feel free to share concern regarding any of it.

yarn.lock Outdated Show resolved Hide resolved
.env.appStore.example Outdated Show resolved Hide resolved
@anikdhabal
Copy link
Contributor

anikdhabal commented Oct 3, 2024

Hey @ponikar I got you! Could you please provide a Loom video of the entire workflow?

@ponikar
Copy link
Author

ponikar commented Oct 4, 2024

Hey @ponikar I got you! Could you please provide a Loom video of the entire workflow?

Sure. Our team will make a video to understand the entire flow.

@anikdhabal
Copy link
Contributor

Sure. Our team will make a video to understand the entire flow.

I mean from our app's perspective: starting with installation from our app store using OAuth, then book an event with this app

@ponikar
Copy link
Author

ponikar commented Oct 4, 2024

Sure. Our team will make a video to understand the entire flow.

I mean from our app's perspective: starting with installation from our app store using OAuth, then book an event with this app

Thanks for the detailed requirement.

@ponikar
Copy link
Author

ponikar commented Oct 4, 2024

@anikdhabal we have some concern regarding how calcom will manage huddle01 flow for older users who is using the old version. Can we connect over slack or email? Please provide your email address to communicate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in community Created by Linear-GitHub Sync ❗️ .env changes contains changes to env variables ✨ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants