-
Notifications
You must be signed in to change notification settings - Fork 16
feat: new template #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new template #369
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@thymikee I can't reproduce the typecheck issue locally, do you know what might be causing this kind of discrepancy? |
Yeah, you'll need to add the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. I've left some questions about code structure:
- Why re-export welcome screen from
welcome
inplatform-xxx
and then doPlatform.select
again? - I would suggest renamign to
@rnef/welcome-screen
to make it event more evident that this package can be removed afterwards from the users project.
|
@jbroma how does it work then? I do not see it in any deps except |
users have |
tbh from the technical perspective it makes more sense to have it explicitly in the projects because |
Import from the shared package directly |
+1 the only reasoning against is that users will have one more explicit dependency in their projects and would need to remove it explicitly after the setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Summary
Closes #325
welcome
package with the templatewelcome
package withplatform-ios
&platform-android
@rnef/welcome
package work withoutpackageExports
Screenshots
Light mode:
Dark mode:
Test plan