feat: Optimize the code for repo topic

cannotfindme · Nov 7, 2021 · 72eab9a · 72eab9a
1 parent f9d9511
commit 72eab9a
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/full-sync.yml b/.github/workflows/full-sync.yml
@@ -26,5 +26,6 @@ jobs:
           TOKEN_OF_GITHUB: ${{ secrets.TOKEN_OF_GITHUB }}
           FULLSYNC_LIMIT: 2000
           PARTIALSYNC_LIMIT: 10
+          REPO_TOPICS_LIMIT: 50
           FULL_SYNC: true
         run: npm start
diff --git a/.github/workflows/partial-sync.yml b/.github/workflows/partial-sync.yml
@@ -35,6 +35,7 @@ jobs:
           TOKEN_OF_GITHUB: ${{ secrets.TOKEN_OF_GITHUB }}
           FULLSYNC_LIMIT: 2000
           PARTIALSYNC_LIMIT: 10
+          REPO_TOPICS_LIMIT: 50
         run: npm start
 
       - uses: actions/upload-artifact@v2

diff --git a/libs/github.ts b/libs/github.ts
@@ -1,6 +1,8 @@
 import { Octokit } from '@octokit/core';
 import { QueryForStarredRepository, Repo, GithubRepositoryTopic, RepositoryTopic } from './types';
 
+const githubTopicsFirst = +process.env.REPO_TOPICS_LIMIT || 50;
+
 export class Github {
     private client: Octokit;
 
@@ -20,10 +22,9 @@ export class Github {
         let cursor = '';
         let hasNextPage = true;
         const repoList = [];
-        const topicFirst = 50;
 
         while (hasNextPage || repoList.length < limit) {
-            const data = await this.getStarredRepoAfterCursor(cursor, topicFirst);
+            const data = await this.getStarredRepoAfterCursor(cursor, githubTopicsFirst);
             repoList.push(
                 ...this.transformGithubStarResponse(data),
             );
@@ -40,11 +41,10 @@ export class Github {
     async getList() {
         // @ts-ignore
         const limit = +process.env.PARTIALSYNC_LIMIT || 10;
-        const topicFirst = 50;
 
         console.log(`Github: Start to sync latest starred repos, limit is ${limit}`);
 
-        const data = await this.getLastStarredRepo(limit, topicFirst);
+        const data = await this.getLastStarredRepo(limit, githubTopicsFirst);
         this.repoList.push(
             ...this.transformGithubStarResponse(data),
         );

diff --git a/readme.md b/readme.md
@@ -11,3 +11,4 @@ Manage all your Github Starred repos with Notion Database and Github Actions;
 - NOTION_API_KEY
 - NOTION_DATABASE_ID
 - TOKEN_OF_GITHUB
+- REPO_TOPICS_LIMIT
diff --git a/readme.zh.md b/readme.zh.md
@@ -19,6 +19,7 @@
 
 - `FULLSYNC_LIMIT` 全量同步的最大 Repo 个数，默认为 2000 个
 - `PARTIALSYNC_LIMIT` 增量同步的最大 Repo 个数，每次增量同步会从后往前取若干条数据，默认为 10 个
+- `REPO_TOPICS_LIMIT` Repo 添加的话题数量，默认取前 50 个
 
 需要在 `github/workflows/*.yml` 中，修改这个配置