Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for required C++ features during initial build (std::format, etc) #3479

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+68 −2
Draft

Check for required C++ features during initial build (std::format, etc) #3479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc38066
added macros for checking and requiring C++ features
mikekasprzak Jul 13, 2024
16756b7
Merge remote-tracking branch 'upstream/main' into required-cxx-features
mikekasprzak Jul 13, 2024
30fb1ee
Added placeholder list of required C++ features
mikekasprzak Jul 13, 2024
93f0fa9
duplicated the test suite changes from #3472
mikekasprzak Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
duplicated the test suite changes from #3472
  • Loading branch information
@mikekasprzak
mikekasprzak committed Jul 13, 2024
commit 93f0fa98b9f82999570462790e49ff0e4ea2ecee
2 changes: 1 addition & 1 deletion .github/workflows/symbols-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:

jobs:
Run:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems incidental. Is this a required part of the PR, or a remnant of a previous test?


timeout-minutes: 10
steps:
Expand Down
2 changes: 1 addition & 1 deletion doc/sphinx/.readthedocs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ version: 2

# Set the version of Python and other tools you might need
build:
os: ubuntu-22.04
os: ubuntu-24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, is this required?

tools:
python: "3.11"
# https://github.com/readthedocs/readthedocs.org/issues/9599
Expand Down
Loading