Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline decorations buffer management #3802

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Streamline decorations buffer management #3802

wants to merge 4 commits into from

Conversation

tarek-y-ismail
Copy link
Contributor

No description provided.

@tarek-y-ismail tarek-y-ismail self-assigned this Mar 6, 2025
AlanGriffiths
AlanGriffiths approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is simpler.

The downside is that it introduces a dependency on libmirplatform-dev, which isn't as stable as we would like it to be. 🤷

@tarek-y-ismail
Copy link
Contributor Author

Yeah, this is simpler.

The downside is that it introduces a dependency on libmirplatform-dev, which isn't as stable as we would like it to be. 🤷

I think keeping things simple while we get user customizable decorations implemented is worth it. What do you think? Is it merge-worthy?

@AlanGriffiths
Copy link
Collaborator

What do you think? Is it merge-worthy?

I approved it. But it's a draft, so didn't queue.

Want to give @RAOF or @Saviq a chance to review? (Opinions can reasonably differ on the libplatform dependency)

@tarek-y-ismail
Copy link
Contributor Author

tarek-y-ismail commented Mar 6, 2025 •
edited
Loading

Want to give @RAOF or @Saviq a chance to review? (Opinions can reasonably differ on the libplatform dependency)

Yeah, my discussion with Chris' was why I noticed all of this to start, so it would be a good idea to get his opinions as well. Saviq's opinion is also welcome if he has the time :)

@tarek-y-ismail tarek-y-ismail requested review from Saviq and RAOF March 6, 2025 14:05
Saviq
Saviq approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinions can reasonably differ on the libplatform dependency

I think server side decorations are bound to the compositor enough that it's not wrong to have a tighter dependency like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq approved these changes

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@RAOF RAOF Awaiting requested review from RAOF

Assignees

@tarek-y-ismail tarek-y-ismail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarek-y-ismail @AlanGriffiths @Saviq