Skip to content

Commit

Permalink
Fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
billy1624 committed Sep 22, 2022
1 parent c2e98b5 commit 77bddd8
Show file tree
Hide file tree
Showing 17 changed files with 165 additions and 67 deletions.
8 changes: 2 additions & 6 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ log = { version = "^0.4" }
tracing = { version = "^0.1", features = ["log"] }
rust_decimal = { version = "^1", optional = true }
sea-orm-macros = { version = "^0.10.0", path = "sea-orm-macros", optional = true }
sea-query = { version = "^0.27", features = ["thread-safe"] }
sea-query-binder = { version = "^0.1", optional = true }
sea-query = { version = "^0.27", git = "https://github.com/SeaQL/sea-query", features = ["thread-safe"] }
sea-query-binder = { version = "^0.1", git = "https://github.com/SeaQL/sea-query", optional = true }
sea-strum = { version = "^0.23", features = ["derive", "sea-orm"] }
serde = { version = "^1.0", features = ["derive"] }
serde_json = { version = "^1.0", optional = true }
Expand All @@ -45,10 +45,6 @@ ouroboros = "0.15"
url = "^2.2"
once_cell = "1.8"

[patch.crates-io]
sea-query = { git = "https://github.com/SeaQL/sea-query" }
sea-query-binder = { git = "https://github.com/SeaQL/sea-query" }

[dev-dependencies]
smol = { version = "^1.2" }
smol-potat = { version = "^1.1" }
Expand Down
5 changes: 1 addition & 4 deletions sea-orm-codegen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ name = "sea_orm_codegen"
path = "src/lib.rs"

[dependencies]
sea-query = { version = "^0.27", features = ["thread-safe"] }
sea-query = { version = "^0.27", git = "https://github.com/SeaQL/sea-query", features = ["thread-safe"] }
syn = { version = "^1", default-features = false, features = [
"derive",
"parsing",
Expand All @@ -31,6 +31,3 @@ tracing = { version = "0.1", features = ["log"] }

[dev-dependencies]
pretty_assertions = { version = "^0.7" }

[patch.crates-io]
sea-query = { git = "https://github.com/SeaQL/sea-query" }
11 changes: 6 additions & 5 deletions sea-orm-codegen/src/entity/active_enum.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,20 @@ use crate::WithSerde;
use heck::CamelCase;
use proc_macro2::TokenStream;
use quote::{format_ident, quote};
use sea_query::DynIden;

#[derive(Clone, Debug)]
pub struct ActiveEnum {
pub(crate) enum_name: String,
pub(crate) values: Vec<String>,
pub(crate) enum_name: DynIden,
pub(crate) values: Vec<DynIden>,
}

impl ActiveEnum {
pub fn impl_active_enum(&self, with_serde: &WithSerde, with_copy_enums: bool) -> TokenStream {
let enum_name = &self.enum_name;
let enum_name = &self.enum_name.to_string();
let enum_iden = format_ident!("{}", enum_name.to_camel_case());
let values = &self.values;
let variants = self.values.iter().map(|v| v.trim()).map(|v| {
let values: Vec<String> = self.values.iter().map(|v| v.to_string()).collect();
let variants = values.iter().map(|v| v.trim()).map(|v| {
if v.chars().all(|c| c.is_numeric()) {
format_ident!("_{}", v)
} else {
Expand Down
6 changes: 3 additions & 3 deletions sea-orm-codegen/src/entity/column.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl Column {
ColumnType::Uuid => "Uuid".to_owned(),
ColumnType::Binary(_) | ColumnType::VarBinary(_) => "Vec<u8>".to_owned(),
ColumnType::Boolean => "bool".to_owned(),
ColumnType::Enum(name, _) => name.to_camel_case(),
ColumnType::Enum { name, .. } => name.to_string().to_camel_case(),
_ => unimplemented!(),
}
.parse()
Expand Down Expand Up @@ -146,8 +146,8 @@ impl Column {
let s = s.to_string();
quote! { ColumnType::Custom(#s.to_owned()).def() }
}
ColumnType::Enum(enum_name, _) => {
let enum_ident = format_ident!("{}", enum_name.to_camel_case());
ColumnType::Enum { name, .. } => {
let enum_ident = format_ident!("{}", name.to_string().to_camel_case());
quote! { #enum_ident::db_type() }
}
#[allow(unreachable_patterns)]
Expand Down
3 changes: 2 additions & 1 deletion sea-orm-codegen/src/entity/relation.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::util::unpack_table_ref;
use heck::{CamelCase, SnakeCase};
use proc_macro2::{Ident, TokenStream};
use quote::{format_ident, quote};
Expand Down Expand Up @@ -155,7 +156,7 @@ impl Relation {
impl From<&TableForeignKey> for Relation {
fn from(tbl_fk: &TableForeignKey) -> Self {
let ref_table = match tbl_fk.get_ref_table() {
Some(s) => s,
Some(s) => unpack_table_ref(s),
None => panic!("RefTable should not be empty"),
};
let columns = tbl_fk.get_columns();
Expand Down
14 changes: 7 additions & 7 deletions sea-orm-codegen/src/entity/transformer.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::{
ActiveEnum, Column, ConjunctRelation, Entity, EntityWriter, Error, PrimaryKey, Relation,
RelationType,
util::unpack_table_ref, ActiveEnum, Column, ConjunctRelation, Entity, EntityWriter, Error,
PrimaryKey, Relation, RelationType,
};
use sea_query::{ColumnSpec, TableCreateStatement};
use std::collections::HashMap;
Expand Down Expand Up @@ -59,12 +59,12 @@ impl EntityTransformer {
col
})
.map(|col| {
if let sea_query::ColumnType::Enum(enum_name, values) = &col.col_type {
if let sea_query::ColumnType::Enum { name, variants } = &col.col_type {
enums.insert(
enum_name.clone(),
name.to_string(),
ActiveEnum {
enum_name: enum_name.clone(),
values: values.clone(),
enum_name: name.clone(),
values: variants.clone(),
},
);
}
Expand All @@ -77,7 +77,7 @@ impl EntityTransformer {
.iter()
.map(|fk_create_stmt| fk_create_stmt.get_foreign_key())
.map(|tbl_fk| {
let ref_tbl = tbl_fk.get_ref_table().unwrap();
let ref_tbl = unpack_table_ref(tbl_fk.get_ref_table().unwrap());
if let Some(count) = ref_table_counts.get_mut(&ref_tbl) {
if *count == 0 {
*count = 1;
Expand Down
4 changes: 2 additions & 2 deletions sea-orm-codegen/src/entity/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ impl EntityWriter {
.columns
.iter()
.fold(TokenStream::new(), |mut ts, col| {
if let sea_query::ColumnType::Enum(enum_name, _) = &col.col_type {
let enum_name = format_ident!("{}", enum_name.to_camel_case());
if let sea_query::ColumnType::Enum { name, .. } = &col.col_type {
let enum_name = format_ident!("{}", name.to_string().to_camel_case());
ts.extend(vec![quote! {
use super::sea_orm_active_enums::#enum_name;
}]);
Expand Down
15 changes: 15 additions & 0 deletions sea-orm-codegen/src/util.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use sea_query::TableRef;

pub(crate) fn escape_rust_keyword<T>(string: T) -> String
where
T: ToString,
Expand All @@ -21,3 +23,16 @@ pub(crate) const RUST_KEYWORDS: [&str; 49] = [
];

pub(crate) const RUST_SPECIAL_KEYWORDS: [&str; 3] = ["crate", "Self", "self"];

pub(crate) fn unpack_table_ref(table_ref: &TableRef) -> String {
match table_ref {
TableRef::Table(tbl)
| TableRef::SchemaTable(_, tbl)
| TableRef::DatabaseSchemaTable(_, _, tbl)
| TableRef::TableAlias(tbl, _)
| TableRef::SchemaTableAlias(_, tbl, _)
| TableRef::DatabaseSchemaTableAlias(_, _, tbl, _)
| TableRef::SubQuery(_, tbl)
| TableRef::ValuesList(_, tbl) => tbl.to_string(),
}
}
57 changes: 53 additions & 4 deletions sea-orm-macros/src/derives/active_enum.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use heck::CamelCase;
use proc_macro2::TokenStream;
use quote::{quote, quote_spanned};
use quote::{format_ident, quote, quote_spanned};
use syn::{parse, punctuated::Punctuated, token::Comma, Expr, Lit, LitInt, LitStr, Meta, UnOp};

enum Error {
Expand Down Expand Up @@ -59,7 +59,10 @@ impl ActiveEnum {
match s.as_ref() {
"Enum" => {
db_type = Ok(quote! {
Enum(Self::name(), Self::values())
Enum {
name: Self::name(),
variants: Self::iden_values(),
}
})
}
_ => {
Expand Down Expand Up @@ -227,13 +230,59 @@ impl ActiveEnum {
quote! { v }
};

let enum_name_iden = format_ident!("{}Enum", ident);

let str_variants: Vec<String> = variants
.iter()
.filter_map(|variant| {
variant
.string_value
.as_ref()
.map(|string_value| string_value.value())
})
.collect();

let impl_enum_variant_iden = if !str_variants.is_empty() {
let enum_variant_iden = format_ident!("{}Variant", ident);
let enum_variants: Vec<syn::Ident> = str_variants
.iter()
.map(|v| format_ident!("{}", v.to_camel_case()))
.collect();

quote!(
#[derive(Debug, Clone, PartialEq, Eq, EnumIter, Iden)]
pub enum #enum_variant_iden {
#(
#[iden = #str_variants]
#enum_variants,
)*
}

impl #ident {
pub fn iden_values() -> Vec<sea_orm::sea_query::DynIden> {
<#enum_variant_iden as sea_orm::strum::IntoEnumIterator>::iter()
.map(|v| sea_orm::sea_query::SeaRc::new(v) as sea_orm::sea_query::DynIden)
.collect()
}
}
)
} else {
quote!()
};

quote!(
#[derive(Debug, Clone, PartialEq, Eq, Iden)]
#[iden = #enum_name]
pub struct #enum_name_iden;

#impl_enum_variant_iden

#[automatically_derived]
impl sea_orm::ActiveEnum for #ident {
type Value = #rs_type;

fn name() -> String {
#enum_name.to_owned()
fn name() -> sea_orm::sea_query::DynIden {
sea_orm::sea_query::SeaRc::new(#enum_name_iden) as sea_orm::sea_query::DynIden
}

fn to_value(&self) -> Self::Value {
Expand Down
2 changes: 1 addition & 1 deletion src/driver/sqlx_sqlite.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use sea_query::Values;
use std::{future::Future, pin::Pin, sync::Arc};

use sqlx::{
sqlite::{SqliteArguments, SqliteConnectOptions, SqliteQueryResult, SqliteRow},
sqlite::{SqliteConnectOptions, SqliteQueryResult, SqliteRow},
Sqlite, SqlitePool,
};

Expand Down
26 changes: 18 additions & 8 deletions src/entity/active_enum.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::{ColumnDef, DbErr, Iterable, TryGetable};
use sea_query::{Nullable, Value, ValueType};
use sea_query::{DynIden, Nullable, Value, ValueType};

/// A Rust representation of enum defined in database.
///
Expand Down Expand Up @@ -37,13 +37,16 @@ use sea_query::{Nullable, Value, ValueType};
/// Small,
/// }
///
/// #[derive(Debug, Iden)]
/// pub struct CategoryEnum;
///
/// impl ActiveEnum for Category {
/// // The macro attribute `rs_type` is being pasted here
/// type Value = String;
///
/// // Will be atomically generated by `DeriveActiveEnum`
/// fn name() -> String {
/// "category".to_owned()
/// fn name() -> DynIden {
/// SeaRc::new(CategoryEnum)
/// }
///
/// // Will be atomically generated by `DeriveActiveEnum`
Expand Down Expand Up @@ -109,7 +112,7 @@ pub trait ActiveEnum: Sized + Iterable {
type Value: Into<Value> + ValueType + Nullable + TryGetable;

/// Get the name of enum
fn name() -> String;
fn name() -> DynIden;

/// Convert enum variant into the corresponding value.
fn to_value(&self) -> Self::Value;
Expand All @@ -134,7 +137,7 @@ pub trait ActiveEnum: Sized + Iterable {
#[cfg(test)]
mod tests {
use crate as sea_orm;
use crate::{entity::prelude::*, *};
use crate::{entity::prelude::*, sea_query::SeaRc, *};
use pretty_assertions::assert_eq;

#[test]
Expand All @@ -145,11 +148,15 @@ mod tests {
Small,
}

#[derive(Debug, Iden)]
#[iden = "category"]
pub struct CategoryEnum;

impl ActiveEnum for Category {
type Value = String;

fn name() -> String {
"category".to_owned()
fn name() -> DynIden {
SeaRc::new(CategoryEnum)
}

fn to_value(&self) -> Self::Value {
Expand Down Expand Up @@ -226,7 +233,10 @@ mod tests {
assert_eq!(Category::db_type(), ColumnType::String(Some(1)).def());
assert_eq!(DeriveCategory::db_type(), ColumnType::String(Some(1)).def());

assert_eq!(Category::name(), DeriveCategory::name());
assert_eq!(
Category::name().to_string(),
DeriveCategory::name().to_string()
);
assert_eq!(Category::values(), DeriveCategory::values());
}

Expand Down
Loading

0 comments on commit 77bddd8

Please sign in to comment.