remove __orientationChanged listener on editbox destroyed (cocos#3464)

caochao · Nov 5, 2018 · ef745b9 · ef745b9
1 parent 7b574ee
commit ef745b9
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/cocos2d/core/components/editbox/CCEditBoxImpl.js b/cocos2d/core/components/editbox/CCEditBoxImpl.js
@@ -245,6 +245,10 @@ let EditBoxImpl = cc.Class({
         this._node = null;
         this.setDelegate(null);
         this.removeDom();
+        if (this.__orientationChanged) {
+            window.removeEventListener('orientationchange', this.__orientationChanged);
+            this.__orientationChanged = null;
+        }
     },
 
     _onTouchBegan (touch) {
@@ -433,10 +437,12 @@ _p.createInput = function() {
 // Called before editbox focus to register cc.view status
 _p._beginEditingOnMobile = function () {
     let self = this;
-    this.__orientationChanged = function () {
-        self._adjustEditBoxPosition();
-    };
-    window.addEventListener('orientationchange', this.__orientationChanged);
+    if (!this.__orientationChanged) {
+        this.__orientationChanged = function () {
+            self._adjustEditBoxPosition();
+        };
+        window.addEventListener('orientationchange', this.__orientationChanged);
+    }
 
     if (cc.view.isAutoFullScreenEnabled()) {
         this.__fullscreen = true;
@@ -465,7 +471,10 @@ _p._endEditingOnMobile = function () {
         this.__rotateScreen = false;
     }
 
-    window.removeEventListener('orientationchange', this.__orientationChanged);
+    if (this.__orientationChanged) {
+        window.removeEventListener('orientationchange', this.__orientationChanged);
+        this.__orientationChanged = null;
+    }
 
     if(this.__fullscreen) {
         cc.view.enableAutoFullScreen(true);